sonatype-lift[bot] commented on code in PR #1753:
URL: https://github.com/apache/solr/pull/1753#discussion_r1252439461
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -73,9 +74,11 @@ protected SolrCore getCoreByCollection(String
collectionName, boolean isPreferLe
public static SolrCore getCore(
Factory factory, HttpSolrCall solrCall, String collectionName, boolean
isPreferLeader) {
- String sytheticCoreName =
factory.collectionVsCoreNameMapping.get(collectionName);
- if (sytheticCoreName != null) {
- return solrCall.cores.getCore(sytheticCoreName);
+ String syntheticCoreName =
factory.collectionVsCoreNameMapping.get(collectionName);
+ if (syntheticCoreName != null) {
+ SolrCore syntheticCore = solrCall.cores.getCore(syntheticCoreName);
Review Comment:
<picture><img alt="7% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
<b>*THREAD_SAFETY_VIOLATION:</b>* Unprotected write. Non-private method
`CoordinatorHttpSolrCall.getCore(...)` indirectly mutates container
`core.SolrResourceLoader.classNameCache` via call to `Map.put(...)` outside of
synchronization.
Reporting because a superclass `class org.apache.solr.servlet.HttpSolrCall`
is annotated `@ThreadSafe`, so we assume that this method can run in parallel
with other non-private methods in the class (including itself).
---
<details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -73,9 +74,11 @@ protected SolrCore getCoreByCollection(String
collectionName, boolean isPreferLe
public static SolrCore getCore(
Factory factory, HttpSolrCall solrCall, String collectionName, boolean
isPreferLeader) {
- String sytheticCoreName =
factory.collectionVsCoreNameMapping.get(collectionName);
- if (sytheticCoreName != null) {
- return solrCall.cores.getCore(sytheticCoreName);
+ String syntheticCoreName =
factory.collectionVsCoreNameMapping.get(collectionName);
Review Comment:
<picture><img alt="7% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
<b>*THREAD_SAFETY_VIOLATION:</b>* Read/Write race. Non-private method
`CoordinatorHttpSolrCall.getCore(...)` reads without synchronization from
container `factory.collectionVsCoreNameMapping` via call to `Map.get(...)`.
Potentially races with write in method `CoordinatorHttpSolrCall.getCore(...)`.
Reporting because a superclass `class org.apache.solr.servlet.HttpSolrCall`
is annotated `@ThreadSafe`, so we assume that this method can run in parallel
with other non-private methods in the class (including itself).
---
<details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
![https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg"){kind=link}