iamsanjay commented on code in PR #1740:
URL: https://github.com/apache/solr/pull/1740#discussion_r1256927914
##########
solr/core/src/java/org/apache/solr/handler/SnapShooter.java:
##########
@@ -277,7 +281,8 @@ public void createSnapAsync(final int numberToKeep,
Consumer<NamedList<?>> resul
* @see IndexDeletionPolicyWrapper#saveCommitPoint
* @see IndexDeletionPolicyWrapper#releaseCommitPoint
*/
- protected NamedList<Object> createSnapshot(final IndexCommit indexCommit)
throws Exception {
+ protected SnapShooterBackupCoreResponse createSnapshot(final IndexCommit
indexCommit)
Review Comment:
`CoreSnapshotResponse` looks good because most of our JerseyResponse classes
ends with 'Response' keyword. There is another class named
`IncrementalBackupCoreResponse.java`. Should I change it to
`IncrementalShardSnapshotResponse.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
