[ https://issues.apache.org/jira/browse/SOLR-16889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742563#comment-17742563 ]
Alex Deparvu edited comment on SOLR-16889 at 7/12/23 9:11 PM: -------------------------------------------------------------- Opened a draft PR. I am missing some resource cleanup on return. something like this finally block (https://github.com/apache/solr/blob/e1f8a6ac75e56d5bfbc5493d99b94ee60f4113d4/solr/core/src/java/org/apache/solr/servlet/ServletUtils.java#L276) {noformat} consumeInputFully(request, response); SolrRequestInfo.reset(); SolrRequestParsers.cleanupMultipartFiles(request); {noformat} but my confusion comes from the existing 'else' block that doesn't to any cleanup, so I am not sure how this is supposed to work https://github.com/apache/solr/blob/e1f8a6ac75e56d5bfbc5493d99b94ee60f4113d4/solr/core/src/java/org/apache/solr/servlet/ServletUtils.java#L290 was (Author: alex.parvulescu): Opened a draft PR. I am missing some resource cleanup on return. something like this finally block (https://github.com/apache/solr/blob/e1f8a6ac75e56d5bfbc5493d99b94ee60f4113d4/solr/core/src/java/org/apache/solr/servlet/ServletUtils.java#L276) {noformat} consumeInputFully(request, response); SolrRequestInfo.reset(); SolrRequestParsers.cleanupMultipartFiles(request); {noformat} but my confusion comes from the exiting 'else' block that doesn't to any cleanup, so I am not sure how this is supposed to work https://github.com/apache/solr/blob/e1f8a6ac75e56d5bfbc5493d99b94ee60f4113d4/solr/core/src/java/org/apache/solr/servlet/ServletUtils.java#L290 > Rate Limiter should stop processing on 429 > ------------------------------------------ > > Key: SOLR-16889 > URL: https://issues.apache.org/jira/browse/SOLR-16889 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Alex Deparvu > Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Rate Limiter can issue a 429 in case of overload but it will not stop > processing the request. > The client side will still get the correct response code. > As discussed on dev list > https://lists.apache.org/thread/92rsf5ojrofsrlol90sd5lwz7qh8lxst -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org