Willdotwhite commented on PR #1759: URL: https://github.com/apache/solr/pull/1759#issuecomment-1637154270
Not sure this is ready to go yet; either my testing is flawed (below), or we're not catching the new flags: ```powershell PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -help -help is not a valid command! PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -usage -usage is not a valid command! PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -h -h is not a valid command! PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd --help --help is not a valid command! PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd /? /? is not a valid command! ``` --- Could someone confirm/deny please: should these new lines ([here](https://github.com/apache/solr/pull/1759/files#diff-118de7ae5d9fc032e479321cb4d3ee62ceb68e9f3c845292b44c5e14c0f769cfR266-R271)): ``` IF "%1"=="-help" goto run_solrcli IF "%1"=="-usage" goto run_solrcli IF "%1"=="-h" goto run_solrcli IF "%1"=="--help" goto run_solrcli IF "%1"=="/?" goto run_solrcli ``` should target the following commands: ``` .\solr.cmd -help .\solr.cmd -usage .\solr.cmd -h .\solr.cmd --help ``` (And I have absolutely no idea what `/?` is all about) If so, is there a roadmap item for adding aliases for those tasks somewhere else? Unless I've massively misunderstood this task, I think the SolrCLI need a tweak to `SolrCLI::main` to catch the new flags (which I'll open as a PR just in case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
