[ https://issues.apache.org/jira/browse/SOLR-16889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743885#comment-17743885 ]
Alex Deparvu commented on SOLR-16889: ------------------------------------- took another look at the part that was confusing (without any resource cleanup) and I believe this is dead code, the tracer object can never be null, so I am assuming this is something that can happen only in test context. updated my PR with cleanup in the case the rate limiter decides to stop a request, and opened it up for review https://github.com/apache/solr/pull/1780 > Rate Limiter should stop processing on 429 > ------------------------------------------ > > Key: SOLR-16889 > URL: https://issues.apache.org/jira/browse/SOLR-16889 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Alex Deparvu > Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Rate Limiter can issue a 429 in case of overload but it will not stop > processing the request. > The client side will still get the correct response code. > As discussed on dev list > https://lists.apache.org/thread/92rsf5ojrofsrlol90sd5lwz7qh8lxst -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org