[GitHub] [solr] justinrsweeney commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

[via GitHub]

justinrsweeney commented on code in PR #1816:
URL: https://github.com/apache/solr/pull/1816#discussion_r1284480906


##########
solr/core/src/test/org/apache/solr/schema/BooleanFieldTest.java:
##########
@@ -17,6 +17,7 @@
 
 package org.apache.solr.schema;
 
+import java.util.Map;
 import org.apache.solr.SolrTestCaseJ4;
 import org.junit.BeforeClass;
 import org.junit.Test;

Review Comment:
   I think you could change this test to use solrconfig-tlog.xml instead of 
solrconfig-basic.xml. That way you could remove the change in this PR to 
solrconfig-basic.xml and keep that one simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org