xtenzQ opened a new pull request, #1829:
URL: https://github.com/apache/solr/pull/1829

   https://issues.apache.org/jira/browse/SOLR-6853
   
   # Description
   
   When adding synonyms or stop words containing the slash `/` character 
through the REST API, it becomes impossible to later remove these words.
   
   # Solution
   
   Rather than only extracting the last one or two strings from the end of the 
URL, I parse it until the managed resource is located or there are no more 
slashes in the `resourceId` path.
   
   # Tests
   
   I added a couple of tests that ensure synonyms and stop words containing a 
slash inside them are removed.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`. (failing at documentation tho)
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to