stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1673926139
> I noticed that we have a test_ssl.bats test that exercises Solr. I wonder if extending those tests would help validate this fix? no, we'd need a proxy server for testing ...unless there is some command line proxy server that is easy to integrate into a bats test. I manually installed one on my local to smoke test this and was able to check http1 and http2 modes. @epugh would you say this is sufficient to push the code in? if there are bugs in more complex setups we can fix them as they come (as opposed to not having this feature in). I would hate to leave this PR open for much longer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
