[ 
https://issues.apache.org/jira/browse/SOLR-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754769#comment-17754769
 ] 

Jan Høydahl commented on SOLR-16936:
------------------------------------

Some use of Span.log today seems to be not time critical, more for tagging the 
span. In that case we could add these as normal span k/v tags and not events. 
In other cases, the timing may be important, then we could keep them as events..

> Consider removal of the Span.addEvent methods
> ---------------------------------------------
>
>                 Key: SOLR-16936
>                 URL: https://issues.apache.org/jira/browse/SOLR-16936
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Alex Deparvu
>            Priority: Minor
>
> It is unclear if the Span.addEvent methods are useful in the span context. 
> I'd like to consider removing them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to