stillalex commented on PR #1853:
URL: https://github.com/apache/solr/pull/1853#issuecomment-1684234505
*Span Data Review*
All requests currently have the root span:
```
Name: name that reflect incoming request (operation, url as template)
(example) get:/{collection}/select
(example) post:/{collection}/update
Tags
db.instance test -- collection or shard name (ex. test OR
test_shard2_replica_n2)
http.method GET
http.request.method GET
http.params _=1692378454124&indent=true&q=*:*&q.op=OR&useParams=
http.response.status_code 200
http.status_code 200
http.url http://localhost:8983/solr/test/select
db.type solr -- fixed value, present on root spans only
internal.span.format proto -- fixed value, present on all spans
otel.library.name solr -- fixed value, present on all spans
span.kind server -- fixed value, present on all spans
```
New child spans covering more of the request processing, added with this PR.
these spans are present on all requests not just Query
```
Name: CollectionsHandler -- dynamic name, the handler class name that
is used for processing this request
Tags
internal.span.format proto -- fixed value, present on all spans
otel.library.name solr -- fixed value, present on all spans
span.kind internal -- fixed value, present on all spans
```
```
Name: writeQueryResponse
Tags
contentType application/json; charset=UTF-8
responseWriter JacksonJsonWriter
internal.span.format proto -- fixed value, present on all spans
otel.library.name solr -- fixed value, present on all spans
span.kind internal -- fixed value, present on all spans
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
