epugh commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1684250474
Great. Will merge when in front of laptop. On Fri, Aug 18, 2023 at 1:29 PM Lamine ***@***.***> wrote: > Hi @epugh <https://github.com/epugh> I'd really appreciate if you could > finish the review and, if approved, merge it. I have other PRs waiting for > this one before I could push them upstream. Thank you. > > are you going to change the -t to a -v for verbose and use that int he > bats test? That way we don't have custom code that is ONLY used in a test.. > it's a more generic feature... I'd love to see that... > > Done. > That's a good suggestion. I can add another PR verbosing more logs. For > now it's just logging *solrhome* as it's the subject of this PR. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/1798#issuecomment-1684221697>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAFO63HFGXDW34T6TXMVLLXV6Q7TANCNFSM6AAAAAA2QJKJYA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
