igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1298863878
##########
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##########
@@ -135,4 +177,10 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex,
Logger log) {
errorInfo.code = code;
return errorInfo;
}
+
+ private static boolean hideStackTrace(SolrCore core) {
+ return core != null
+ ? core.getCoreContainer().hideStackTrace()
+ : Boolean.parseBoolean(System.getProperty("solr.hideStackTrace"));
Review Comment:
Something similar was done in latest commit. Thanks.
##########
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##########
@@ -135,4 +177,10 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex,
Logger log) {
errorInfo.code = code;
return errorInfo;
}
+
+ private static boolean hideStackTrace(SolrCore core) {
+ return core != null
+ ? core.getCoreContainer().hideStackTrace()
+ : Boolean.parseBoolean(System.getProperty("solr.hideStackTrace"));
Review Comment:
@stillalex : Thanks for your comments. For some reason, the unit test in
this PR is now failing, before I even try to modify anything. Is anyone aware
of changes in the code path of a response that would prevent going though these
methods of ResponseUtils? I'll keep trying, but, no luck after a couple of
hours so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
