dsmiley commented on PR #1827: URL: https://github.com/apache/solr/pull/1827#issuecomment-1687328255
Instructions: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests Somehow I think it can be set to automatic so you don't have to think about it henceforth, but I'm not sure. About some changes I did: * Don't use SolrTestCaseHS at all, even the assertJQ thing. There is only one trivial assert so it's easy to have it assert the manual way. Still... it's curious that the JSON path expression didn't work. I dug into that but it's a distraction here. * The configSet needs to be a copy because we modify it. The ~3 lines for this are kinda ugly but it's for another time to improve it. * Using a very minimal configSet. There is still some tidying up for you to do based on my comments. I also think the test data should be simplified because your test doesn't even use half of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
