gerlowskija opened a new pull request, #1859:
URL: https://github.com/apache/solr/pull/1859

   https://issues.apache.org/jira/browse/SOLR-16825
   
   # Description
   
   SOLR-16825 added a new gradle module, 'api', which holds v2 API definitions 
as interfaces.  This allows us to generate an OAS (and SolrRequest 
implementations from that) as a part of the solrj build.
   
   But these artifacts (the OAS and generated Java code), only cover the v2 
APIs that have interfaces in the 'api' module.  We need to extract interfaces 
to live in 'api' for each v2 API in 'core' that doesn't already have one.
     
   # Solution
   
   This PR creates 'api' interfaces for a number of v2 APIs, allowing 
SolrRequest implementations to be generated for them.  The following APIs are 
covered in this PR:
   
   - delete replica property
   - delete replica
   - delete (i.e. "clear") node
   - delete collection snapshot
   - delete collection backup
   
   
   # Tests
   
   Manual inspection of the generated OAS and SolrRequest implementations.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to