stillalex commented on PR #1119: URL: https://github.com/apache/solr/pull/1119#issuecomment-1688919453
@gerlowskija updated the PR, please take a look and let me know what you think. the test will fail on purpose to show that the correct class was called, but because it's a static util method it's a bit more tricky to mock. I did not do any manual testing yet and I think some param validation might still be needed. crave build is failing because it's not able to apply patch - I think the branch is too old? we could do a quick rebase to bring this up to a fresher revision. let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
