tpunder opened a new pull request, #1861: URL: https://github.com/apache/solr/pull/1861
https://issues.apache.org/jira/browse/SOLR-16945 # Description This adds opt-in multi-threaded warming support to CaffeineCache and QuerySenderListener. # Solution The implementation for both CaffeineCache and QuerySenderListener are basically the same. They both now make use of an `ExecutorUtil.MDCAwareThreadPoolExecutor` with the user configured number of threads to run any warming queries. If multi-threaded warming was not configured (or the number of threads is set to 0 or 1) then the existing single-threaded implementation is used. If a negative number of threads are specified then `Runtime.getRuntime().availableProcessors()` is used for the number of threads. The multi-threaded implementation is opt-in. # Tests I've run manual tests on this change to verify the single-threaded and multi-threaded code paths are working as expected based on logging messages showing the threads used for the warming queries and based on the total time it takes to run the warming with various numbers of threads. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
