epugh commented on PR #1834: URL: https://github.com/apache/solr/pull/1834#issuecomment-1689818267
> I am a bit confused, so why would we need an assert at a place where it is impossible for the Socket to be null? Because otherwise precommit fails ;-). We really should figure out why Precommit fails, and get the underlying problem fixed, maybe for another PR?. I'm going to go ahead and get this merged as tests passed locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
