janhoy commented on code in PR #1725: URL: https://github.com/apache/solr/pull/1725#discussion_r1304289358
########## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.util.circuitbreaker; + +import com.google.common.annotations.VisibleForTesting; +import java.util.ArrayList; +import java.util.List; + +/** + * Keeps track of all registered circuit breaker instances. Responsible for a holistic view of + * whether a circuit breaker has tripped or not. + * + * <p>There are two typical ways of using this class's instance: 1. Check if any circuit breaker has + * triggered -- and know which circuit breaker has triggered. 2. Get an instance of a specific + * circuit breaker and perform checks. + * + * <p>It is a good practice to register new circuit breakers here if you want them checked for every + * request. + * + * <p>NOTE: The current way of registering new default circuit breakers is minimal and not a long + * term solution. There will be a follow up with a SIP for a schema API design. Review Comment: Agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org