[ https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758663#comment-17758663 ]
Chris M. Hostetter commented on SOLR-15367: ------------------------------------------- I didn't dig into the impl that much, but conceptually this seems good to me. one nit pick ... {code:java} public static final boolean TRACE_ID_GEN_ENABLED = !Boolean.getBoolean("solr.disable.alwaysOnTraceId");{code} It feels like it would be a lot cleaner to use {{"solr.alwaysOnTraceId"}} which defaults to "true" and people configured {{-Dsolr.alwaysOnTraceId=false}} if they don't want it. Also: If this feature is going to _default_ to "on" we should probably update {{./solr/server/resources/log4j2.xml}} to include... {code:java} %notEmpty{t:%X{trace_id}}{code} right? > Convert "rid" functionality into a default Tracer > ------------------------------------------------- > > Key: SOLR-15367 > URL: https://issues.apache.org/jira/browse/SOLR-15367 > Project: Solr > Issue Type: Improvement > Components: tracing > Reporter: David Smiley > Assignee: David Smiley > Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > Solr's "rid" (request ID) functionality added in SOLR-14566 could be > converted into a distributed-tracing OpenTracing Tracer (Solr > TracerConfigurator) plugin, more or less. Such an implementation, enabled by > default, would merely generate IDs and pass them along in a custom HTTP > header. Solr's existing tracing support would then ensure that this ID is in > MDC in the "t:" log prefix, and thus would fit in nicely. "rid" is kind of a > cheap bolt-on by comparison, duplicative with tracing but far fewer features. > Solr's tracing support is growing, supporting more Solr-to-Solr interaction > than "rid" which is only in a search request. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org