stillalex commented on PR #1864: URL: https://github.com/apache/solr/pull/1864#issuecomment-1693694755
this looks very good! much easier to follow along! the only minor suggestion would be to add the `isExpensive()` method to implementors of `CoreAdminAPIBase` which look like candidates for expensiveness: `BackupCoreAPI`, `RestoreCoreAPI` maybe other too but I don't really know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
