[ 
https://issues.apache.org/jira/browse/SOLR-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759311#comment-17759311
 ] 

ASF subversion and git services commented on SOLR-16623:
--------------------------------------------------------

Commit 7a88bd84c19b4b2bc0cd08827d7d4fad3ed15518 in solr's branch 
refs/heads/main from Joshua Ouma
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=7a88bd84c19 ]

SOLR-16623: new SolrJettyTestRule (#1374)

Introduce SolrJettyTestRule, a new subclass of SolrClientTestRule for tests 
requiring Jetty or HTTP.
Perhaps most tests using JettySolrRunner could convert to this eventually.

Only converted SolrJettyTestBase, (thus the many tests using it) which should 
be considered a deprecated test utility now. Don’t need a base test class just 
to use Jetty; you simply need to use SolrJettyTestRule. Changed many of these 
subclasses in trivial ways like to reduce Jetty references.

Moved SolrJettyTestBase.legacyExampleCollection1SolrHome to SolrTestCaseJ4 
because wasn’t Jetty related; was used by non-Jetty tests.


Co-authored-by: David Smiley <dsmi...@salesforce.com>

> SolrClientTestRule for JettySolrRunner
> --------------------------------------
>
>                 Key: SOLR-16623
>                 URL: https://issues.apache.org/jira/browse/SOLR-16623
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: David Smiley
>            Priority: Minor
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> (Sub-Task) Add a subclass of SolrClientTestRule (created in a sibling issue) 
> for JettySolrRunner.  Convert SolrJettyTestBase to use it, which contains 
> some useful logic already that might migrate into such a rule.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to