janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311948300
########## solr/CHANGES.txt: ########## @@ -147,6 +149,8 @@ Bug Fixes * SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter (Christina Chortaria, Max Kadel, Ryan Laddusaw, Jane Sandberg, David Smiley) +* SOLR-16900: Add/fix wrong/missing "solr.home" to zkcli scripts (Lamine Idjeraoui. Review by Eric Pugh & Jason Gerlowski) Review Comment: Unrelated edit? ########## solr/CHANGES.txt: ########## @@ -107,6 +107,8 @@ Improvements * SOLR-16927: Allow SolrClientCache clients to use Jetty HTTP2 clients (Alex Deparvu, David Smiley) +* SOLR-16897: Add support of OAuth 2.0/OIDC 'code with PKCE' flow - back-end (Lamine Idjeraoui. Review and contribution by janhoy. Review by Kevin Risden) Review Comment: Simply list the contributors, no need to qualify what each one contributed. Github will set author and add `Co-authored-by: John Doe <j...@doe.com>` for code contributors in final merge message. Also, no ned for two CHANGES entris even if you split it in two PRs with two commits. Suggest to add both JIRA numbers in same line: ```suggestion * SOLR-16896, SOLR-16897: Add support of OAuth 2.0/OIDC 'code with PKCE' flow (Lamine Idjeraoui, janhoy, Kevin Risden) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
