stillalex commented on code in PR #1898:
URL: https://github.com/apache/solr/pull/1898#discussion_r1319810929
##########
solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java:
##########
@@ -277,9 +279,23 @@ public static EchoParamStyle get(String v) {
* <p>Defaults to 'false' if not specified.
*
* @see #REQUEST_ID
+ * @see #DISABLE_REQUEST_ID_DEFAULT
+ * @deprecated this was replaced by the auto-generated trace ids
*/
+ @Deprecated(since = "9.4")
String DISABLE_REQUEST_ID = "disableRequestId";
+ /**
+ * An opt-out flag to prevent the addition of {@link #REQUEST_ID} tracing on
distributed queries
+ *
+ * <p>Defaults to 'false' if not specified.
+ *
+ * @see #DISABLE_REQUEST_ID
+ * @deprecated this was replaced by the auto-generated trace ids
+ */
+ @Deprecated(since = "9.4")
+ boolean DISABLE_REQUEST_ID_DEFAULT =
Boolean.getBoolean("solr.disableRequestId");
Review Comment:
makes sense to not have this in the CommonParams. will move to the
SearchHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
