stillalex commented on PR #1632: URL: https://github.com/apache/solr/pull/1632#issuecomment-1714298498
@dsmiley I am attempting to rewrite the test using thew new `EmbeddedSolrServerTestRule` but I am falling short. First it seems to shortcut exceptions in the response via `checkForExceptions(rsp);` method so there is no opportunity for the stacktrace to be populated in the response, what I see now is just the exception being thrown so cannot verify the `hideStackTrace` flag does anything. Second it seems to hardcode the response to the binary response (see `BinaryResponseWriter.getParsedResponse`), so not sure if this might need to change to support other types, for this test it is needed to serialize the error to verify the trace is not there. please correct if I am missing something obvious here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
