risdenk commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1731554823
I ran into this reproducing failure - `gradlew test --tests LeaderElectionIntegrationTest.testSimpleSliceLeaderElection -Dtests.seed=7FE90E71BD77ABA3 -Dtests.locale=ga-Latn-IE -Dtests.timezone=Hongkong -Dtests.asserts=true -Dtests.file.encoding=UTF-8` which looks to be an issue in the `LeaderElectionIntegrationTest` - it was passing previously because the leader retry was waiting for a zookeeper state change. The improvement I made checks the ZK state directly and there is no wait for a state change. [d1f1554](https://github.com/apache/solr/pull/1945/commits/d1f1554aab2aa945a6ae50e9c583a4773598e67b) improves the test to make sure Jetty actually shutdown before trying to find a new leader. There is no guarantee prior to this change that a leader change has taken place before Jetty has shutdown completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
