stillalex commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1340547130
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -145,4 +151,34 @@ public Codec getCodec() {
assert core != null : "inform must be called first";
return codec;
}
+
+ /**
+ * This class exists because Lucene95HnswVectorsFormat's getMaxDimensions
method is final and we
+ * need to workaround that constraint to allow more than the default number
of dimensions
+ */
Review Comment:
> Perhaps overengineering but something like
https://github.com/apache/lucene/blob/releases/lucene/9.8.0/lucene/core/src/test/org/apache/lucene/index/TestFilterCodecReader.java#L30
could be added as a test to ensure all that needs delegating is delegated.
it does feel like overkill for this
> And perhaps the workaround class could be final itself and even private?
sure, this makes sense. I was concerned with the name being involved in the
SPI lookup somehow making things weird. I can test it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
