sigram commented on code in PR #75:
URL: https://github.com/apache/solr-sandbox/pull/75#discussion_r1344396006
##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -329,7 +329,7 @@ void
processResult(ConsumerRecord<String,MirroredSolrRequest> record, IQueueHand
log.trace("result=failed-resubmit");
}
metrics.counter("failed-resubmit").inc();
- kafkaMirroringSink.submit(record.value());
+ kafkaMirroringSink.submit(result.newItem());
Review Comment:
this should do the trick :)
BTW, I don't like the name `_newItem` and this method suggests as if we were
creating something new, which we're not. Why not `item` and `getItem()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
