dsmiley commented on code in PR #1928:
URL: https://github.com/apache/solr/pull/1928#discussion_r1346434338
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java:
##########
@@ -325,20 +326,18 @@ public static List<ReplicaPosition>
getNodesForNewReplicas(
ClusterState clusterState,
String collectionName,
String shard,
- int nrtReplicas,
- int tlogReplicas,
- int pullReplicas,
+ ReplicaCount numReplicas,
Object createNodeSet,
SolrCloudManager cloudManager,
CoreContainer coreContainer)
throws IOException, InterruptedException, AssignmentException {
- log.debug(
- "getNodesForNewReplicas() shard: {} , nrtReplicas : {} , tlogReplicas:
{} , pullReplicas: {} , createNodeSet {}",
- shard,
- nrtReplicas,
- tlogReplicas,
- pullReplicas,
- createNodeSet);
+ if (log.isDebugEnabled()) {
+ log.debug(
+ "getNodesForNewReplicas() shard={}, {} , createNodeSet={}",
+ shard,
+ numReplicas.toDebugString(),
Review Comment:
Might it be reasonable for ReplicaCount.toString() to be this debug string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
