janhoy commented on code in PR #2000:
URL: https://github.com/apache/solr/pull/2000#discussion_r1353433719
##########
solr/bin/solr:
##########
@@ -1913,26 +1913,29 @@ function start_solr() {
# shellcheck disable=SC2086
nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS
-Dsolr.log.muteconsole \
-jar start.jar "${SOLR_JETTY_CONFIG[@]}" $SOLR_JETTY_ADDL_CONFIG \
- 1>"$SOLR_LOGS_DIR/solr-$SOLR_PORT-console.log" 2>&1 & echo $! >
"$SOLR_PID_DIR/solr-$SOLR_PORT.pid"
+ 1>"$SOLR_LOGS_DIR/solr-$SOLR_PORT-console.log" 2>&1 & echo $! >
"$SOLR_PID_DIR/solr-$SOLR_PORT.pid"
Review Comment:
That line actually had a `\t` char which made it look weird, Pushed a fix.
Now in my IDE the line is aligned with the one above it (view the new file
outside the diff and you'll see)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]