jzonthemtn commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355287827
########## versions.props: ########## @@ -70,3 +70,4 @@ org.semver4j:semver4j=5.2.1 org.slf4j:*=2.0.9 org.xerial.snappy:snappy-java=1.1.10.5 software.amazon.awssdk:*=2.20.155 +org.apache.opennlp:opennlp*=2.2.0 Review Comment: This is overriding the version of OpenNLP that is brought in via Lucene which is still using OpenNLP 1.9.x. I don't know of any interface changes offhand between 1.9.x and 2.2.x so changing to 2.2.x would likely be safe, but is this a good thing to do instead of getting the dependency version updated in Lucene? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
