pvcnt commented on code in PR #1973:
URL: https://github.com/apache/solr/pull/1973#discussion_r1360417880
##########
solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java:
##########
@@ -125,6 +125,13 @@ public ZkWriteCommand createCollection(ClusterState
clusterState, ZkNodeProps me
collectionProps.put(ZkStateReader.CONFIGNAME_PROP, configName);
}
+ // add user-defined properties
+ for (String prop : message.keySet()) {
Review Comment:
I did not find those methods on a ZkNodeProps object, or did I overlooked
something?
##########
solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc:
##########
@@ -250,6 +250,7 @@ If `true` the states of individual replicas will be
maintained as individual chi
+
Set core property _name_ to _value_.
See the section xref:configuration-guide:core-discovery.adoc[] for details on
supported properties and values.
Review Comment:
To confirm I understood well, are you mentioning the fact that we can add
arbitrary properties (e.g., "foo" or "bar") this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
