janhoy commented on PR #649:
URL: https://github.com/apache/solr-operator/pull/649#issuecomment-1783915257
Alternatively, should perhaps the spec for `cp-solr-xml` init container be
defined in yaml for the crd, e.g.:
```yaml
spec:
cpSolrXmlInitContainer:
image:
registry: docker.io
repository: busybox
tag: 1.36.1-glibc
imagePullPolicy: IfNotPresent
securityContext:
runAsUser: 65534
runAsGroup: 65534
runAsNonRoot: true
```
It would move some configuration from code out to values, which is always
good. End users could then override only what they need, e.g. to use your own
image with a different registry and user:
```yaml
spec:
cpSolrXmlInitContainer:
image:
registry: public.ecr.aws
repository: my-company/busybox
tag: 1.37.0-custom
imagePullSecret: foo
securityContext:
runAsUser: 1000
runAsGroup: 1000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
