cpoerschke commented on code in PR #2069: URL: https://github.com/apache/solr/pull/2069#discussion_r1391126010
########## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ########## @@ -32,8 +32,25 @@ Setting the `shards.tolerant=true` parameter on requests can help with graceful circuit breaker thresholds are reached on some nodes. See the <<shards.tolerant Parameter>> for details. == Circuit Breaker Configurations -All circuit breaker configurations are listed as independent `<circuitBreaker>` entries in `solrconfig.xml` as shown below. -A circuit breaker can register itself to trip for query requests and/or update requests. By default only search requests are affected. A user may register multiple circuit breakers of the same type with different thresholds for each request type. +Circuit breakers can be configured globally for the entire node, or for each collection individually, or a combination. Per-collection circit breakers take precedence over global circuit breakers. Review Comment: How about keeping the existing logic and illustrating in the docs what a global/local combination would typically look like e.g. ``` - ... Per-collection circuit breakers are checked before global circuit breakers, and if there is a conflict, the per-collection circuit breaker takes precedence. ... + ... Per-collection circuit breakers are checked before global circuit breakers, and if there is a conflict, the per-collection circuit breaker takes precedence. Typically, any per-collection circuit breaker thresholds are set lower than global thresholds. ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
