pvcnt commented on code in PR #2039:
URL: https://github.com/apache/solr/pull/2039#discussion_r1409398398
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java:
##########
@@ -61,6 +122,11 @@ public boolean contains(Replica.Type type) {
return countByType.containsKey(type);
}
+ /** Returns the replica types for which a number of replicas was explicitely
defined. */
+ public Set<Replica.Type> keySet() {
Review Comment:
It's used every time I need to iterate over replica types explicitly defined
in this class. A similar behaviour could be obtained by iterating over all
`Replica.Type#values` and calling `ReplicaCount#contains`, but it seemed more
straightforward this way. We could also have a `ReplicaCoubt#forEach` method...
So many ways to implement this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
