murblanc commented on code in PR #2039:
URL: https://github.com/apache/solr/pull/2039#discussion_r1410498382
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java:
##########
@@ -100,6 +166,10 @@ public int total() {
return countByType.values().stream().reduce(Integer::sum).orElse(0);
}
+ public int count(EnumSet<Replica.Type> replicaTypes) {
Review Comment:
Until we get to that point (of real separation of API vs implementation) I'd
favor code simplicity and readability because I see no real practical impact of
keeping SolrJ lean while I do see drawbacks of having more complex code overall.
Would like others to chime in here.
@HoustonPutman @dsmiley for example, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
