pjmcarthur opened a new pull request, #2126: URL: https://github.com/apache/solr/pull/2126
https://issues.apache.org/jira/browse/SOLR-17096 # Description It should be possible to install and manage the configuration of a cluster singleton plugin in an immutable deployment of SolrCloud. Currently, the only method to manage cluster singleton plugin configs is by using the `ContainerPluginApi` edit APIs, and this is not always possible, especially in the case of immutable SolrCloud deployments. # Solution This PR changes the `ContainerPluginRegistry` to use a pluggable source for plugin configs. The pluggable source is determined by a system propert, `solr.containerPluginsSource`, or by a declaration in solr.xml. The default source is `ZkContainerPluginsSource`, which allows plugins to be added, removed or updated at runtime using the `ContainerPluginApi`. This matches the existing behavior. A new OOTB plugin implementation is `NodeConfigContainerPluginsSource`. This plugin supports managing cluster singleton plugins via declarations in solr.xml, and does not support the edit APIs of `ContainerPluginApi`; these APIs are not registered in the case that node config is used as the plugin source. An example of solr.xml that supports cluster singleton declarations would be ``` <containerPluginsSource class="org.apache.solr.api.NodeConfigContainerPluginsSource"/> <clusterSingleton name="my.singleton.name" class="my.singleton.class"> <config>...</config> </clusterSingleton> ``` # Tests New tests are added in `NodeConfigContainerPluginsSourceTest` that spin up clusters and Core containers using the node config plugin source, and verify that cluster singleton declarations in solr.xml are added correctly to the `ContainerPluginsRegistry`. I have not updated any documentation (or CHANGES.txt) yet, pending comments here. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
