jdyer1 commented on PR #2099: URL: https://github.com/apache/solr/pull/2099#issuecomment-1846231319
@janhoy With my last update, I am cautiously optimistic this PR may help us with the failure rate. With this change, the test passes even if I change `localhost` to `localhost.localdomain` in my `/etc/hosts` file. (I am trying this as a modest attempt to mimic the environmental conditions when it fails in our CI.) However, carefully consider the changes I am making to `JWTIssuerConfig.java`. Here I am assuming the host name check bypass for `localhost` exists merely to help unit tests with self-signed certificates. Perhaps we are also helping users who try this functionality on their laptops? I think with my change it will work for either case, but maybe we also want to exempt `InetAddress.getLoopbackAddress().getHostName()` as well (as far as I can tell this will always return `localhost`). It would be much better if we could use the Mock library's self-signed certificate generation, as you suggest. This would greatly streamline this test and keep the focus were it belongs! Unfortunately with the short amount of time I spent I was unable to make it work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
