janhoy commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1453182213


##########
solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java:
##########
@@ -75,6 +73,8 @@
 public class ContainerPluginsRegistry implements ClusterPropertiesListener, 
MapWriter, Closeable {
   private static final Logger log = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
+  public static final String MUTABLE_CLUSTER_PLUGINS = 
"solr.cluster.plugin.mutable";

Review Comment:
   Yea, one can argue how far the naming standard should go. I was mostly 
concerned with the lowercase dot separated aspect, with a controlled set of 
top-level categories. Guess it is nice-to-have to also agree on 
"enabled/disabled", "edit/mutable", "allowlist/includelist" etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to