cpoerschke commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1917629755
Thanks @rahulgoswami for opening this pull request!
May I suggest to undo the removal of the `.sha1` file -- it appears to be
unrelated to the handler changes (and tidy or precommit prompting for the
removal needs separate investigation i.e. thanks for indirectly surfacing this
issue).
> Added fieldFlags.add("termCount", terms.size()) in
SegmentsInfoRequestHandler to add termsCount when ?fieldInfo=true
optional suggestion: addition of class level javadocs to make the
`fieldInfo=true` parameter more discoverable
> No specific test cases added since currently there are no test cases for
individual properties in the handler output.
optional suggestion: additional test coverage e.g. expanding
`SegmentsInfoRequestHandlerTest.testFieldInfo`
https://github.com/apache/solr/blob/releases/solr/9.4.1/solr/core/src/test/org/apache/solr/handler/admin/SegmentsInfoRequestHandlerTest.java#L155-L179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
