cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1488384166
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -1806,7 +1813,7 @@ private void getDocListNC(QueryResult qr, QueryCommand
cmd) throws IOException {
int last = len;
Review Comment:
existing code: personally I would find more `final` use in this method
helpful, #2258 proposes to add it, I'm happy to resolve any merge conflicts
that this may cause for the pull request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
