epugh commented on code in PR #2297: URL: https://github.com/apache/solr/pull/2297#discussion_r1501697688
########## solr/bin/solr: ########## @@ -873,6 +873,12 @@ if [[ "$SCRIPT_CMD" == "delete" ]]; then exit $? fi +# Prevent any zk subcommands from going through with out invoking zk command +if [[ "$SCRIPT_CMD" == "upconfig" || $SCRIPT_CMD == "downconfig" || $SCRIPT_CMD == "cp" || $SCRIPT_CMD == "rm" || $SCRIPT_CMD == "mv" || $SCRIPT_CMD == "ls" || $SCRIPT_CMD == "mkroot" ]]; then Review Comment: Yeah, I did not like it. main is shell and sub commands are java... so thats why `bin/solr cp` actually is executed in java code. Now, if we move this all over to more how the `bin/solr package <subcommand>` then we wouldn't need this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
