cpoerschke commented on code in PR #2315:
URL: https://github.com/apache/solr/pull/2315#discussion_r1505661209
##########
solr/core/src/java/org/apache/solr/response/transform/ValueAugmenterFactory.java:
##########
@@ -72,7 +72,7 @@ public DocTransformer create(String field, SolrParams params,
SolrQueryRequest r
return new ValueAugmenter(field, val);
}
- static class ValueAugmenter extends DocTransformer {
+ public static class ValueAugmenter extends DocTransformer {
final String name;
final Object value;
Review Comment:
Wondering about visibility needs here if the class itself becomes public and
is extended e.g.
```suggestion
private final String name;
private final Object value;
```
or
```suggestion
private final String name;
protected final Object value;
```
or both public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
