epugh commented on code in PR #2321: URL: https://github.com/apache/solr/pull/2321#discussion_r1506788112
########## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java: ########## @@ -132,15 +132,12 @@ private static StreamExpressionNamedParameter generateNamedParameterExpression(S } } - // If contains ` replace with " + // If contains ` replace with ". Preserves ` which are escaped. Review Comment: COuld we rework this comment? NOt sure I understand the ` " . Preserves` text...? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org