mariemat commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1509204591


##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -984,8 +985,13 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest 
sreq) {
         if (srsp.getSolrResponse() != null) {
           nl.add("time", srsp.getSolrResponse().getElapsedTime());
         }
-
-        shardInfo.add(srsp.getShard(), nl);

Review Comment:
   This is only when the client requests `shards.info=true` so it feels 
preferable to return the error as this is typically used when debugging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to