cpoerschke commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-1973524446
> @cpoerschke [34c7db0](https://github.com/apache/solr/commit/34c7db09e08693a79d87eaa6e43ad6f5aacbc342) No; that is a single FixedBitSet and as such you've basically changed this to Solr's existing default handling, more or less. But that's not thread-safe! Hmm, but each `FixedBitSet` is in a `FixedBitSetCollector` and multiple `FixedBitSetCollector` objects are created via the `CollectorManager.newCollector()` calls and then merged via the `CollectorManager.reduce()` call into a separate joint `FixedBitSet`? Anyhow, I can revert the commit, that's what version control is for sometimes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
