dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1516376085
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -261,22 +260,23 @@ public String getMessage() {
}
}
- private static HttpClient createHttpClient(
- SolrCore core,
- String httpBasicAuthUser,
- String httpBasicAuthPassword,
- boolean useCompression) {
+ private Http2SolrClient createHttpClient(
Review Comment:
rename to "createSolrClient" so we don't confuse a lower level httpClient
with a solrClient. Whenever I see a method/field/param name saying
"httpClient" but the type is actually "SolrClient"; it irks me. httpSolrClient
is fine if you prefer.
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -261,22 +260,23 @@ public String getMessage() {
}
}
- private static HttpClient createHttpClient(
- SolrCore core,
- String httpBasicAuthUser,
- String httpBasicAuthPassword,
- boolean useCompression) {
+ private Http2SolrClient createHttpClient(
+ SolrCore core, String httpBasicAuthUser, String httpBasicAuthPassword,
String leaderBaseUrl) {
final ModifiableSolrParams httpClientParams = new ModifiableSolrParams();
Review Comment:
This is now unused. I'd hope that authentication stuff would be handled in
some other way (e.g. via configuration / initialization in UpdateShardHandler
creating the recoveryOnlyHttpClient) so that internal Solr code here can merely
get this pre-configured client. That client should also already have an
InstrumentedHttpListenerFactory too; no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
