cdrini commented on code in PR #2162: URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the list of constraints to |Optional |Default: `0` |=== + -The `facet.mincount` parameter specifies the minimum counts required for a facet field to be included in the response. +The minimum count required for a facet field to be included in the response. If a field's counts are below the minimum, the field's facet is not returned. Review Comment: Good question! I think I might leave this as is, since I don't fully understand how these terms are supposed to differ. These terms really need a good untangling in this document. If I get the time I'll tackle this in a separate PR to tidy it up! ########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -113,7 +113,7 @@ This does not limit the query in any way, only the facets that would be returned |Optional |Default: none |=== + -If `facet.contains` is used, the `facet.contains.ignoreCase` parameter causes case to be ignored when matching the given substring against candidate facet terms. +Causes case to be ignored when matching the `facet.contains` substring against candidate facet terms. Review Comment: Nice, this appears to be consistent with other lines on this page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
