AndreyBozhko opened a new pull request, #2356:
URL: https://github.com/apache/solr/pull/2356

   https://issues.apache.org/jira/browse/SOLR-12089
   
   
   # Description
   
   Updated the Ref Guide about Spell Checking.
   
   
   
   Also, I noticed some inconsistencies with how different spell checkers 
accept accuracy parameter:
   
   - `FileBasedSpellChecker` and `IndexBasedSpellChecker` expect a string which 
is then parsed as float,
   - `DirectSolrSpellChecker` can handle input as both string and float.
   As for the existing examples in the Ref Guide - even though they were 
technically correct - it is still confusing that some examples suggest to 
provide accuracy as string, while other suggest to use a float.
   
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [x] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to