magibney commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-2012621142
Any thoughts on #2349 ? This issue creates a lot of log noise 😓 >>Maybe the error occurs while it's deleting a child tree, and the rest of the files arent' deleted? >Yeah I expect that'd be the case. Btw I no longer think there's a race condition leaving the file tree partially undeleted. >The stack trace to me looks like it could be there are 2 things doing the delete and its a race condition who gets there first? Otherwise I don't see how we would end up getting this exception. This isn't the top level path right? The stack trace says this is happening while walking the file tree... I think this is very likely a top-level path -- it's "walking the file tree", but it just hasn't gotten beyond the top level yet. In the vast majority of cases the approach taken by this PR should be fine (i.e. would not lead to partial deletion or other failure). Still, if we can get away with handling this in a stricter way I still think that's preferable. In the unlikely event that some other non-solr process really _is_ deleting stuff, we'd want to know about it; and if we swallow this error, we would have no way of knowing there's a problem. I think it's well within our ability to properly order the deletes for all the tracked directories -- the logic was already basically there, it just wasn't working in all cases, and #2349 should fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
