epugh commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1535512663
########## solr/server/scripts/cloud-scripts/zkcli.sh: ########## @@ -13,6 +13,21 @@ log4j_config="file:$sdir/../../resources/log4j2-console.xml" solr_home="$sdir/../../solr" +# Get solr dir with fullpath Review Comment: I would LOVE to see that refactoring on `SolrZkClient`.. I've been looking more at that code base, and I think there is a LOT of opportunity for clean up. We have a LOT of tickets that are around reducing what is in _solr_ and _solr.cmd_ in favour of Java code, so this is a bit of a step in the wrong direction! ########## solr/modules/aws-secret-provider/README.md: ########## @@ -0,0 +1,95 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +Apache Solr - AWS Secret Provider +=========================== + +An implementation of `ZkCredentialsInjector` that pulls Zookeeper credentials from an AWS Secret Manager. + +This plugin uses the [default AWS credentials provider chain](https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/credentials.html), so ensure that your credentials are set appropriately (e.g., via env var, or in `~/.aws/credentials`, etc.). + +## Usage + +- To enable this feature edit solr.in.sh/cmd and set/add `SOLR_MODULES=aws-secret-provider` + + + +- Create a secret in AWS SM (for example named *zkCredentialsSecret*) containing the Zookeeper credentials in the following Json format: + + + +```json + { + "zkCredentials": [ + {"username": "admin-user", "password": "ADMIN-PASSWORD", "perms": "all"}, + {"username": "readonly-user", "password": "READONLY-PASSWORD", "perms": "read"} + ] + } +``` + + +- Pass the secret name and region trough `solr.in.sh:` Review Comment: "through"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
